-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial cssProps feature #389
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cristianbote/goober-rocks/C5vaEo8p2XUiNsjhRBxDfagBzdGM |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f23d677:
|
@B-Teague let fn = (name) => (...args) => `${name}(${args.join()})`
let rgb = fn('rgb')
// Removed old syntax
/*
css({
"color": "rgb(224,224,224)",
"backgroundColor": "rgb(32,32,32)"
})
*/
css({
color: rgb(224, 224, 224),
backgroundColor: rgb(32,32,32)
})
// Removed old syntax
/*
styled`
color: ${({ color: { r, g, b } }) => `rgb(${r}, ${g}, ${b})`};
background-color: ${({ color: { r, g, b } }) => `rgb(${r}, ${g}, ${b})`};
`
*/
styled`
color: ${({ color: { r, g, b } }) => rgb(r, g, b)};
background-color: ${({ color: { r, g, b } }) => rgb(r, g, b)};
` Can I join to this pr??? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@cristianbote This is finally ready for a serious review. I still expect quite a few changes from review, but cssProps is 90% done. Take a look at the readme here: https://github.com/B-Teague/goober/tree/cssProps/cssProps 1879 tests pass, 5 failed (@rules) |
Hi @cristianbote, this is still very much a work in progress (so don't merge yet), but wanted to get your feedback before I go too far down the rabbit hole.
Can you create an official feature branch in the goober repo, and we can merge rough draft updates to that branch and squash all the commits before merging the branch to master once it is ready for production?
I need your feedback on how you want to setup the import paths: import '@goober/css' and also review the new package.json file.
Let me know if you like the new directory structure / folder names.
There are five main features:
Great news, the syntax is even simpler than my initial issue #382.
There is still a lot of work to do before this is production ready, but I got several tests working.
Design Goals:
Todo: