Skip to content

Conversation

@fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Feb 11, 2021

changes summary

  • Weaver 2.0 with multiple items revamped into more suitable modules, such as conversion between ogc-api/pywps/owslib/cwl processes / app-packages.

  • WPS 1/2 endpoint (default /ows/wps) allows both GET KVP and POST XML WPS-Execute request, which are both dispatched to the same job worker operation as WPS-REST endpoint (fixes [Feature] Handle WPS-1.x/2.x execute request as WPS-3 'job' #126, relates to [Feature] Handle Accept header for JSON/XML response in WPS 2.0 #125)

    • Returned response is formatted as JSON/XML according to provided Accept header.
    • Added tests for each combination running a 'demo' docker application.
    • Started documenting the WPS-1/2 endpoint in the rendered OpenAPI (/api and /json) (relates to [Feature] Document XML schemas #146)
  • Adjusted some tests to allow running offline using WebTest.TestApp instead of relying on live instance.

  • Add Github Actions test suite execution

  • Add sample docker-compose setup for API / Worker config to run Docker application packages.

  • use branch pywps-4.4 with latest developments

  • many linting fixes that were not applied

  • some devops patches in makefile that caused disjoint install (not pip dev install) which resulted in desync configs between 'run' and 'debug' mode of pyramid app.

Built on top of the other open PRs.
closes #207
closes #208
closes #209

@fmigneault fmigneault marked this pull request as draft February 11, 2021 01:38
@fmigneault fmigneault self-assigned this Feb 12, 2021
@fmigneault fmigneault added project/DACCS Related to DACCS project (https://github.com/orgs/DACCS-Climate) triage/enhancement New feature or request labels Feb 12, 2021
@fmigneault fmigneault requested a review from dbyrns February 12, 2021 07:06
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #214 (a6f9874) into master (cf4ae2f) will increase coverage by 2.15%.
The diff coverage is 77.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   66.71%   68.86%   +2.15%     
==========================================
  Files          56       61       +5     
  Lines        7082     7446     +364     
  Branches     1102     1137      +35     
==========================================
+ Hits         4725     5128     +403     
+ Misses       2077     2003      -74     
- Partials      280      315      +35     
Impacted Files Coverage Δ
weaver/app.py 0.00% <0.00%> (-53.13%) ⬇️
weaver/processes/esgf_process.py 0.00% <0.00%> (ø)
weaver/processes/wps1_process.py 0.00% <0.00%> (ø)
weaver/processes/wps3_process.py 50.25% <ø> (ø)
weaver/processes/wps_workflow.py 0.00% <0.00%> (ø)
weaver/status.py 93.47% <ø> (ø)
weaver/typedefs.py 0.00% <ø> (ø)
weaver/datatype.py 62.50% <39.47%> (+1.07%) ⬆️
weaver/processes/builtin/utils.py 50.00% <50.00%> (+50.00%) ⬆️
weaver/wps_restapi/colander_extras.py 77.27% <50.00%> (-1.30%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4ae2f...a6f9874. Read the comment docs.

Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup! I only got 4 comments.

@fmigneault fmigneault marked this pull request as ready for review February 17, 2021 02:10
@fmigneault fmigneault requested a review from dbyrns February 17, 2021 02:10
dbyrns
dbyrns previously approved these changes Feb 17, 2021
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your answers. Ready to merge.

@fmigneault fmigneault merged commit dbce4ca into master Feb 22, 2021
@fmigneault fmigneault deleted the weaver-2 branch February 22, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project/DACCS Related to DACCS project (https://github.com/orgs/DACCS-Climate) triage/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Handle WPS-1.x/2.x execute request as WPS-3 'job'

3 participants