Make it possible to decode streams of messages #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exported the 'Decoder' class. - Added 'bytesRemaining' property to decoder class. - Added a wrapper method for 'Decoder.parse' in order to keep the 'bytesRemaining' from updating on parse failure.
|
Looks neat, do you still want this merged? Not sure how I missed this PR. |
|
Feel free to merge it, but the msgpack spec has evolved and now has a way to distinguish between byte and text strings, so I wouldn't use this library. https://github.com/mcollina/msgpack5 implements the latest version. In any case, there's a way to design a msgpack parser that is fully reentrant without backtracking(rolling back to previous parse position in case of missing data). This is one of the reasons I have created https://github.com/tarruda/libmpack, but didn't get the time to put together a node.js binding yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'bytesRemaining' from updating on parse failure.