support custom defaults on types that implement encoding.TextUnmarshaler #56
support custom defaults on types that implement encoding.TextUnmarshaler #56llorllale wants to merge 4 commits intocreasty:masterfrom
Conversation
|
hmm any hints as to why we're still building against an unsupported version of Go? |
@servusdei2018 can I get your feedback on this? |
Oh I believe in the context of #45, checking It's definitely possible to bump to go1.17; as of now even the slower distros (e.g. Debian Bookworm) are up to go1.19, so a bump to 1.17 would be fine I think. It's probably be best to bump the required Go version to the minimum necessary for the language features and standard library changes used in this project but not further so that we maintain compatibility as much as possible with people using older releases. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 95.97% 96.12% +0.15%
==========================================
Files 2 2
Lines 149 155 +6
==========================================
+ Hits 143 149 +6
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
coming back to this:
|
This is pretty much the same proposal as in #45 except for:
encoding.TextUnmarshalerinterfacePreserves non-initial values from being reset with a default valueREADME