-
Notifications
You must be signed in to change notification settings - Fork 255
Fix duplicate imports #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate imports #4715
Conversation
Reviewer's Guide by SourceryThis pull request removes duplicate imports of the Updated class diagram for ClusterConfigclassDiagram
class ClusterConfig {
-ClusterType crcpreset.Preset
-ClusterCACert string
-KubeConfig string
-KubeAdminPass string
}
note for ClusterConfig "ClusterType's type changed from preset.Preset to crcpreset.Preset"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Hi @sebrandon1. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sebrandon1 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good job on breaking this out into a separate PR for easier review.
- Consider using
go mod tidy
to automatically fix the imports.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Broken out from #4712 for easier reviewing.
In this change,
"github.com/crc-org/crc/v2/pkg/crc/preset"
was imported more than once in these files and newer versions of GolangCI-lint were throwing errors.Summary by Sourcery
Remove duplicate imports of the preset package and standardize import alias
Bug Fixes:
Enhancements: