Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preinstalled djgpp image in workflows #53

Closed

Conversation

volkertb
Copy link
Collaborator

@volkertb volkertb commented Dec 19, 2023

Hopefully this will speed up the pipelines, since DJGPP doesn't have to be downloaded and installed in each pipeline when they are run on this image that already includes a DJGPP installation.

Also, using specific image versions should make the builds fully reproducible.

For the project that builds and publishes this image, see https://github.com/volkertb/debian-djgpp

…'t have to be downloaded and installed in each pipeline
…workflow (best to limit this to only `main` before merging)
@@ -4,28 +4,21 @@ on:
push:
branches:
- main
- set-up-cicd
- use-preinstalled-djgpp-image-in-workflows
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed before merging this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow could also be run for all PRs against main, but skip the Github releases part (using conditions) if we're not on main?

Copy link
Collaborator

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to modify the container image, not the runner.

@volkertb
Copy link
Collaborator Author

volkertb commented Dec 20, 2023

@thp @crazii I'm closing this PR, at least for the time being. I need to rethink part of this, since I would have to include certain tools in the builder image, specifically for building and packaging this project (wget, git, shellcheck, perhaps others I've missed so far).

The best course of action:

  • Offer a PR to https://github.com/andrewwutw/build-djgpp that builds and publishes a container image whenever a new version of DJGPP is released. An additional advantage of this is that the image would be "owned" by the same GitHub user that maintains the DJGPP repository on GitHub (andrewwutw).
  • Create a separate GitHub project that builds and publishes an SBEMU-specific build container image that uses that official DJGPP image as its base image.
  • Create a new PR in the SBEMU project to use that SBEMU-specific build image in the GitHub Actions workflows.

Of course I'm open to any suggestions for further improvements, as well as any simpler alternatives that could provide comparable benefits (primarily faster builds).

@volkertb volkertb closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants