-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use preinstalled djgpp image in workflows #53
Use preinstalled djgpp image in workflows #53
Conversation
…'t have to be downloaded and installed in each pipeline
…workflow (best to limit this to only `main` before merging)
@@ -4,28 +4,21 @@ on: | |||
push: | |||
branches: | |||
- main | |||
- set-up-cicd | |||
- use-preinstalled-djgpp-image-in-workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed before merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow could also be run for all PRs against main
, but skip the Github releases part (using conditions) if we're not on main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to modify the container image, not the runner.
Co-authored-by: Thomas Perl <[email protected]>
Co-authored-by: Thomas Perl <[email protected]>
…R Checks workflow, so the build container image does not have to include it
@thp @crazii I'm closing this PR, at least for the time being. I need to rethink part of this, since I would have to include certain tools in the builder image, specifically for building and packaging this project ( The best course of action:
Of course I'm open to any suggestions for further improvements, as well as any simpler alternatives that could provide comparable benefits (primarily faster builds). |
Hopefully this will speed up the pipelines, since DJGPP doesn't have to be downloaded and installed in each pipeline when they are run on this image that already includes a DJGPP installation.
Also, using specific image versions should make the builds fully reproducible.
For the project that builds and publishes this image, see https://github.com/volkertb/debian-djgpp