Feature/raw cargo opts

[bazaah]

Adds a parameter 'test_args_raw' that allows users to pass raw args/options to cargo/libtest.

It also refactors how conditional checks are handled: rather than checking all combinations of bools for each endpoint, it builds up a variable, which is passed to cargo test. This makes the logic easier to extend and reason about.

Finally, the various eq / ne conditionals have their syntax altered:

• Changed 'true' (string) => true (bool)
• Swapped arg positions so the correct type coercion occurs

[jonhoo]

Thanks, this is a cool change! I've left some inline notes :)

[bazaah]

As a side note, is there a pipelines syntax checker?

[jonhoo]

Sadly no, not as far as I'm aware. They have a JSON schema that can be used to validate, but not sure it really helps much with things like debugging templates :( Might be something that's worthwhile to suggest over in the Azure DevOps Developer Community. They're decently responsive there.

[jonhoo]

This looks great now! Only thing missing is docs. I'd take particular care to point out that raw_opts must contain -- to separate cargo and libtest arguments if you set it, and that while setting raw_opts, arguments injected by other options (like ignored and single_threaded) are still added.

For writing the docs, this needs documenting both in configuration.md (for the new parameter to stages.yml), and in the entries for test and tests in custom.md.

[jonhoo]

I had one thought last night -- do you think that any cargo arguments one passes through this one would also want passed to cargo check or to clippy (which also compiles the crate)?

I also just realized that we need to also pass these arguments to coverage, otherwise the test suite won't run correctly there.

[bazaah]

I had one thought last night -- do you think that any cargo arguments one passes through this one would also want passed to cargo check or to clippy (which also compiles the crate)?

I also just realized that we need to also pass these arguments to coverage, otherwise the test suite won't run correctly there.

I'm not sure, I haven't looked into the overlap between them. It might be problem but I haven't run into issues yet.

[jonhoo]

I think it comes down to whether you require those arguments to be passed to compile, or whether they are just "nice to haves". Similarly, for coverage, can tests be run without those additional arguments, or can they not? If they can't then we definitely need to pass the flags to tarpaulin for coverage too. If you can't compile without them, they also need to be passed to cargo check and clippy.