Increase tick for overlapping (tick,lane) groups in sus serialization#147
Open
altalk23 wants to merge 3 commits intocrash5band:masterfrom
Open
Increase tick for overlapping (tick,lane) groups in sus serialization#147altalk23 wants to merge 3 commits intocrash5band:masterfrom
altalk23 wants to merge 3 commits intocrash5band:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sus format isn't very good at overlapping points, and what people do currently is offset endpoints manually so that they dont overlap. this pr changes SusSerializer::scoreToSus to do an overlap check at the end to adjust overlapping ones.
this uses an unordered set to store (tick,lane) pairs so it might have little performance impact, but considering exporting already sorts everything this is miniscule compared to that.