Skip to content

Commit

Permalink
Unbreak spurious fails in gdb.base/step-line.exp
Browse files Browse the repository at this point in the history
My copyright year update in the copyright headers of the step-line
testcase caused it to start failing, due to shift in line numbers.

    FAIL: gdb.base/step-line.exp: continue to f1
    FAIL: gdb.base/step-line.exp: next to dummy 2
    FAIL: gdb.base/step-line.exp: next over dummy 2
    FAIL: gdb.base/step-line.exp: step into f2
    FAIL: gdb.base/step-line.exp: next over dummy 4
    FAIL: gdb.base/step-line.exp: next to dummy 5
    FAIL: gdb.base/step-line.exp: next to dummy 6
    FAIL: gdb.base/step-line.exp: next over dummy 6
    FAIL: gdb.base/step-line.exp: next to dummy 7
    FAIL: gdb.base/step-line.exp: next to dummy 8
    FAIL: gdb.base/step-line.exp: next over dummy 8
    FAIL: gdb.base/step-line.exp: next to dummy 9
    FAIL: gdb.base/step-line.exp: next to dummy 10
    FAIL: gdb.base/step-line.exp: next over dummy 10

This was caused by the copyright.py script after I changed it to
also update this testcase, which made the following transformation:

    -   Copyright (C) 2001-2017
    -   Free Software Foundation, Inc.
    +   Copyright (C) 2001-2018 Free Software Foundation, Inc.

We can easily unbreak the testcase without having to go back to
manual edits each year by adding an extra line in the header.

gdb/testsuite/ChangeLog:

	* gdb.base/step-line.c: Add extra empty line in copyright header.
        * gdb.base/step-line.inp: Likewise.

Tested on x86_64-linux.
  • Loading branch information
brobecke committed Jan 3, 2018
1 parent 39f2fa1 commit bd570f8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions gdb/testsuite/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2018-01-03 Joel Brobecker <[email protected]>

* gdb.base/step-line.c: Add extra empty line in copyright header.
* gdb.base/step-line.inp: Likewise.

2018-01-02 Joel Brobecker <[email protected]>

* gdb.ada/dyn_stride.exp: Add slice test.
Expand Down
1 change: 1 addition & 0 deletions gdb/testsuite/gdb.base/step-line.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* Test step/next in presence of #line directives.
Copyright (C) 2001-2018 Free Software Foundation, Inc.
This file is part of GDB.
Expand Down
1 change: 1 addition & 0 deletions gdb/testsuite/gdb.base/step-line.inp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Test step/next in presence of #line directives

# Copyright (C) 2001-2018 Free Software Foundation, Inc.

# This program is free software; you can redistribute it and/or modify
Expand Down

0 comments on commit bd570f8

Please sign in to comment.