Feat: Add support for Bosch with temperature float value#2068
Open
zhixuan2333 wants to merge 7 commits intocrankyoldgit:masterfrom
Open
Feat: Add support for Bosch with temperature float value#2068zhixuan2333 wants to merge 7 commits intocrankyoldgit:masterfrom
zhixuan2333 wants to merge 7 commits intocrankyoldgit:masterfrom
Conversation
crankyoldgit
requested changes
Feb 19, 2024
Owner
crankyoldgit
left a comment
There was a problem hiding this comment.
First off, thanks for taking the time and effort to improve the library.
Appologies for all the suggestions/questions.
Can you please also provide some state[] corresponding to the 0.5deg additions so we can add some unit tests to verify and check the code against known-good data?
Author
and also here. |
crankyoldgit
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/spreadsheets/d/1gf2wcYWTul5B5qxhGLA25nAKQwmfrvwjtUM3SG4Ty9M/edit?usp=sharing