Change how list query parameters are constructed #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for building such a helpful library! I was doing some stuff with labels and discovered that the way list query parameters were being built wasn't in line with how the api wanted it (not sure if this is just something that has changed recently or what), and since I needed to query two labels I figured I'd take a crack at fixing it.
Quick summary of what this does.
Originally parameters that were a list looked like this in the request:
With this change, the same parameters:
Let me know if anything looks off, or if there was a reason you were doing things this way (maybe it breaks other array parameters? I've only tried
label_ids
). I'm happy to update if needed.