Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how list query parameters are constructed #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

philwade
Copy link

Hey, thanks for building such a helpful library! I was doing some stuff with labels and discovered that the way list query parameters were being built wasn't in line with how the api wanted it (not sure if this is just something that has changed recently or what), and since I needed to query two labels I figured I'd take a crack at fixing it.

Quick summary of what this does.

Originally parameters that were a list looked like this in the request:

&listParam=val1,val2,val3

With this change, the same parameters:

&listParam=val1&listParam=val2&listParam=val3

Let me know if anything looks off, or if there was a reason you were doing things this way (maybe it breaks other array parameters? I've only tried label_ids). I'm happy to update if needed.

@philwade
Copy link
Author

Whoops, didn't notice the tests, my mistake - I'll get them working again and add some for my case

@philwade
Copy link
Author

I've gotten the tests working locally now, I believe the travis failures are the result of an elixir version mismatch. I can look into updating the .travis.yml if you want, but don't want to step on toes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant