Fix OpenAI streams with empty tool_calls arrays - #996
Draft
lc4t wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_callsarraytool_calls: []Root cause
The OpenAI SSE interceptor treated any present
delta.tool_callsvalue as a handled tool-call delta. Because empty arrays are truthy in JavaScript, providers that includetool_calls: []on ordinary content or terminal chunks caused those chunks to be suppressed. Pi then received[DONE]without the upstreamfinish_reason: "stop"chunk and reportedStream ended without finish_reason.Changes
delta.tool_callsto contain at least one entry before entering the tool-call buffering pathfinish_reason: "stop", and[DONE]pass through whentool_callsis emptyTesting
bun testacross the OpenAI interceptor SSE, relay, hint, response-repair, and validation suites: 43 passed, 0 failedbun run typecheck:sharedfinish_reason: "stop", and[DONE]are all preservedgit diff --checkValidation note
bun run typecheck:allcould not complete because the v0.11.2 checkout does not contain the roottsconfig.base.jsonreferenced by several package configs. The affectedpackages/sharedtypecheck passes.Fixes #995