Fix excluded filter inheritance for new sessions - #994
Open
heyankitpatel wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Craft Agent <agents-noreply@craft.do>
Co-Authored-By: Craft Agent <agents-noreply@craft.do>
heyankitpatel
marked this pull request as ready for review
July 28, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix new-session filter inheritance so only filters in
includemode are considered. Excluded status, label, and project filters now leave new sessions on workspace defaults unless exactly one separate included filter is active.Fixes #970
Changes
apps/electron/resources/release-notes/next.mdTesting
bun test apps/electron/src/renderer/components/app-shell/__tests__/new-session-filter-inheritance.test.ts— 5 passedbun test apps/electron/src/renderer/components/app-shell/__tests__— 45 passedbun run typecheck:electron— passedAppShell.tsxhook warnings remain)bun run lint:electron— currentmainhas 9 errors in unrelated, untouched files; no errors are reported in this PR's changed TypeScript filesbun run typecheck:all— cannot complete on currentmainbecausepackages/core/tsconfig.jsonextends a roottsconfig.base.jsonthat is absent from the OSS checkout; the affected Electron package type check passesScreenshots
Not applicable — this changes session creation behavior without visual changes.