fix(server-core): pass persisted gitBashPath to SDK subprocess via envOverrides - #939
Open
changjing9527 wants to merge 1 commit into
Open
Conversation
…vOverrides
When gitBashPath is configured in config.json, it was not forwarded to
the SDK subprocess through session envOverrides. While it was set on
process.env at startup and in the gitbash.CHECK handler, it was
missing from the explicit envOverrides map used when spawning the SDK
subprocess for both Pi and Claude backends.
This caused the bash tool to fall back to its internal hardcoded paths
("C:\Program Files\Git\bin\bash.exe" and
"C:\Program Files (x86)\Git\bin\bash.exe"), silently ignoring the
user's custom gitBashPath for non-standard Git installations.
Fixes craft-ai-agents#935
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Hi everyone, Any plans to merge this in the near future? If not, I'll go ahead and put together a custom build :-) Best, Cyrille |
Author
|
Hi folks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…vOverrides
When gitBashPath is configured in config.json, it was not forwarded to the SDK subprocess through session envOverrides. While it was set on process.env at startup and in the gitbash.CHECK handler, it was missing from the explicit envOverrides map used when spawning the SDK subprocess for both Pi and Claude backends.
This caused the bash tool to fall back to its internal hardcoded paths ("C:\Program Files\Git\bin\bash.exe" and
"C:\Program Files (x86)\Git\bin\bash.exe"), silently ignoring the user's custom gitBashPath for non-standard Git installations.
Fixes #935