Conversation
|
An automated preview of the documentation is available at https://324.int128.prtest3.cppalliance.org/libs/int128/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-02-10 18:55:15 UTC |
pps83
reviewed
Feb 10, 2026
Contributor
|
I'd still add std::to_string for native types. This code basically checks it against charconv, but it really should match std::to_string for int types (this would also catch bugs like the one charconv had) |
pps83
approved these changes
Feb 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #324 +/- ##
========================================
Coverage 99.02% 99.03%
========================================
Files 61 63 +2
Lines 5318 5369 +51
Branches 1643 1661 +18
========================================
+ Hits 5266 5317 +51
Misses 21 21
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #317