Skip to content

[WIP] update transparent plotting demo #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Mar 5, 2025

Summary by Sourcery

Updates the transparent plotting demo to use the new BIDS-Model structure and improve the visualisation of results, including ROI contours.

Enhancements:

  • Updates the transparent plotting demo to use the new BIDS-Model structure.
  • Improves the visualisation of results, including ROI contours.
  • Uses the montage settings from the model.

Copy link
Contributor

sourcery-ai bot commented Mar 5, 2025

Reviewer's Guide by Sourcery

This pull request streamlines the transparent plotting demo by reading the configuration directly from the model, simplifying the layer configuration, and removing redundant steps. This results in a cleaner and more efficient implementation.

Updated class diagram for layers configuration

classDiagram
    class sd_config_layers {
        -layers
        +init(layer_types)
    }

    note for sd_config_layers "The number of layers has been reduced from 4 to 3. The contour layer for the left ROI has been removed."
Loading

File-Level Changes

Change Details Files
Streamlined the configuration process for transparent plotting by directly utilizing the information from the model and removing redundant steps.
  • Removed manual specification of results and directly read them from the model.
  • Removed BIDS layout querying for ROI files.
  • Consolidated ROI contour plotting to use a single mask file.
  • Removed the fourth layer related to ROI contour.
  • Updated opacity range for the dual-coded layer.
  • Set slice display settings based on the model configuration.
demos/MoAE/moae_03_slice_display.m
Updated the layers configuration to use a single contour file.
  • Replaced the right and left ROI files with a single contour file.
  • Removed the fourth layer related to the left ROI file.
demos/MoAE/moae_03_slice_display.m

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Remi-Gau - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It might be helpful to include a brief explanation of the purpose of this demo in the description.
  • Consider adding comments to explain the purpose of key variables and sections of code to improve readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.86%. Comparing base (f53979a) to head (ea2c383).
Report is 161 commits behind head on main.

Files with missing lines Patch % Lines
src/stats/results/checkMontage.m 69.56% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f53979a) and HEAD (ea2c383). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (f53979a) HEAD (ea2c383)
cli 1 0
ubuntu-latest_matlab-R2023a_fast 1 0
octave 2 1
ubuntu-latest_matlab-R2023a_slow 1 0
macos-latest_matlab-R2023a_fast 1 0
macos-latest_matlab-R2023a_slow 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1354       +/-   ##
===========================================
- Coverage   79.57%   53.86%   -25.72%     
===========================================
  Files         285      285               
  Lines        7742     7758       +16     
  Branches       40        0       -40     
===========================================
- Hits         6161     4179     -1982     
- Misses       1565     3579     +2014     
+ Partials       16        0       -16     
Flag Coverage Δ
cli ?
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 53.86% <69.56%> (-21.86%) ⬇️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant