-
Notifications
You must be signed in to change notification settings - Fork 14
[WIP] update transparent plotting demo #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request streamlines the transparent plotting demo by reading the configuration directly from the model, simplifying the layer configuration, and removing redundant steps. This results in a cleaner and more efficient implementation. Updated class diagram for layers configurationclassDiagram
class sd_config_layers {
-layers
+init(layer_types)
}
note for sd_config_layers "The number of layers has been reduced from 4 to 3. The contour layer for the left ROI has been removed."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Remi-Gau - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be helpful to include a brief explanation of the purpose of this demo in the description.
- Consider adding comments to explain the purpose of key variables and sections of code to improve readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
===========================================
- Coverage 79.57% 53.86% -25.72%
===========================================
Files 285 285
Lines 7742 7758 +16
Branches 40 0 -40
===========================================
- Hits 6161 4179 -1982
- Misses 1565 3579 +2014
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Updates the transparent plotting demo to use the new BIDS-Model structure and improve the visualisation of results, including ROI contours.
Enhancements: