[container.node] Exposition-only formatting for node handle members #8555
+44
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
expos-node-handle
branch
8 times, most recently
from
3984380 to
d411e40
Compare
jwakely
requested changes
Nov 20, 2025
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
I like the change, but let's clean the wording up while you're touching it anyway.
frederick-vs-ja
force-pushed
the
expos-node-handle
branch
6 times, most recently
from
104b4b0 to
72a8ccf
Compare
jwakely
approved these changes
Nov 20, 2025
frederick-vs-ja
force-pushed
the
expos-node-handle
branch
3 times, most recently
from
9cdf2d5 to
3a5eb40
Compare
SainoNamkho
reviewed
Nov 20, 2025
Also changes `container_node_type` and `ator_traits` to _`container-node-type`_ and _`ator-traits`_ respectively. And adds missed "is `true`".
frederick-vs-ja
force-pushed
the
expos-node-handle
branch
from
3a5eb40 to
4e6d8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes
container_node_typeandator_traitstocontainer-node-typeandator-traitsrespectively. And adds missed "istrue".