Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New media type support #128

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

New media type support #128

wants to merge 22 commits into from

Conversation

Panosfunk
Copy link
Contributor

@Panosfunk Panosfunk commented Sep 25, 2024 •
edited
Loading

New media type is supported in the instructions step.
That can be achieved by adding

  • "imagePath": "url"
  • "audioPath": "url"
  • "videoPath": "url"

@Panosfunk Panosfunk self-assigned this Sep 25, 2024
@Panosfunk Panosfunk marked this pull request as ready for review October 2, 2024 10:29
@Panosfunk Panosfunk requested a review from bardram October 2, 2024 10:29
@bardram
Copy link
Contributor

bardram commented Oct 9, 2024 •
edited
Loading

The example app throws an error when running:

image

Seems to be on video initialization.

@bardram
Copy link
Contributor

bardram commented Oct 9, 2024 •
edited
Loading

When showing a picture, it is way too small...?????

2024-10-09 14 34 50

@bardram
Copy link
Contributor

bardram commented Oct 9, 2024 •
edited
Loading

The PLAY button is not shown on audio....

2024-10-09 14 43 51

bardram
bardram requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bardram bardram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three media types fails or have errors.....

@Panosfunk
Copy link
Contributor Author

All media types should support assets as well

@Panosfunk
Copy link
Contributor Author

Panosfunk commented Oct 11, 2024 •
edited
Loading

The PLAY button is not shown on audio....

fixed

@Panosfunk
Copy link
Contributor Author

When showing a picture, it is way too small...?????

Fixed

@Panosfunk
Copy link
Contributor Author

All media types should support assets as well

Fixed

@Panosfunk
Copy link
Contributor Author

The example app throws an error when running:

Fixed

@Panosfunk Panosfunk requested a review from bardram October 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bardram bardram Awaiting requested review from bardram

Requested changes must be addressed to merge this pull request.

Assignees

@Panosfunk Panosfunk

Labels
None yet
Projects
None yet
Milestone
Need to check if image and audio supp...
Development

Successfully merging this pull request may close these issues.
3 participants
@Panosfunk @bardram @mario-bermonti