[DAT-63] fix: Inconsistent sort due to per-field limit #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flexsearch returns results grouped on matching field, for instance:
```
{
"path": [doc1, doc2, ...],
"name": [doc2, doc4, ...]
}
```
It enforces the limit on each field. Which mean we might end
up in a situation where a file is skipped from the `name` array, but
appear on the `path` array.
As we have a sort order making the results appear first when it has a
match on the `name` compared to those with a match on the `path`, it
can lead to inconsistent results display.
Therefore, we enforce our own limit restriction, after sorting.
paultranvan
changed the title
Ldoppea
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexsearch returns results grouped on matching field, for instance:
It enforces the limit on each field. Which mean we might end
up in a situation where a file is skipped from the
namearray, butappear on the
patharray.As we have a sort order making the results appear first when it has a match on the
namecompared to those with a match on thepath, it can lead to inconsistent results display.Therefore, we enforce our own limit restriction, after sorting.