[DAT-66] Handle missing path #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replicating files from CouchDB, we do not retrieve path, as it is not persisted in database. Therefore, we dynamically compute the path when a search returns files results. Note we do it at this moment rather than at replication time, because this operation requires to query the parent directory, which can be done directly in-memory through the store once the search index is built, rather than an additional server query for each replicated file.
Ldoppea
approved these changes
Oct 28, 2024
paultranvan
added a commit
that referenced
this pull request
Oct 30, 2024
Since #6, we noticed a severe performance degradation when performing search. We measured the following: - Flexsearch search: <ms - Query cozy-client store to get file paths: ~120ms for 60 files. - Results normalization: ~3ms We used to make multiple `getById` queries to get file path, each of them taking few ms. So we tried to use a `getByIds` instead, and got ~70ms per query, which is better, but still slow. Then, we tried the following: ``` const allFiles = client.getCollectionFromState(FILES_DOCTYPE) as IOCozyFile[] const dirs = allFiles.filter(file => file.type === TYPE_DIRECTORY) return dirs.filter(dir => dirIds.includes(dir._id)) ``` This takes 2ms. We should eventually investigate why the store queries are so slow, but for now let's use this trick.
paultranvan
added a commit
that referenced
this pull request
Oct 30, 2024
Since #6, we noticed a severe performance degradation when performing search. We measured the following: - Flexsearch search: <ms - Query cozy-client store to get file paths: ~120ms for 60 files. - Results normalization: ~3ms We used to make multiple `getById` queries to get file path, each of them taking few ms. So we tried to use a `getByIds` instead, and got ~70ms per query, which is better, but still slow. Then, we tried the following: ``` const allFiles = client.getCollectionFromState(FILES_DOCTYPE) as IOCozyFile[] const dirs = allFiles.filter(file => file.type === TYPE_DIRECTORY) return dirs.filter(dir => dirIds.includes(dir._id)) ``` This takes 2ms. We should eventually investigate why the store queries are so slow, but for now let's use this trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replicating files from CouchDB, we do not retrieve path, as it is
not persisted in database.
Therefore, we dynamically compute the path when a search returns files
results.
Note we do it at this moment rather than at replication time, because
this operation requires to query the parent directory, which can be done
directly in-memory through the store once the search index is built,
rather than an additional server query for each replicated file.