Reset for old browser #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know store Pouch db names in indexeddb. This is useful for cleanup, for browsers not supporting the `indexeddb.databases()` function.
We rely on the `indexedDb.databases()` method to iterate over all local db to be removed, at login time. We also do it later, in the `SharedWorkerProvider` as a fallback. However, this does not work for old browsers that do not support this function. Therefore, we now store the db names locally in PouchLink, and rely on it to remove the databases.
Crash--
reviewed
Oct 1, 2025
| if (db.name) { | ||
| window.indexedDB.deleteDatabase(db.name) | ||
| log.info('Deleted indexedDB database : ', db.name) | ||
| } |
There was a problem hiding this comment.
no fallback for old browser?
There was a problem hiding this comment.
I hesitated but thought it's not worth the effort:
- it's a fallback that should be rarely useful
- our workaround is not perfect
- old browsers are not safe either way
Crash--
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on the
indexedDb.databases()method to iterate over all localdb to be removed, at login time. We also do it later, in the
SharedWorkerProvideras a fallback.However, this does not work for old browsers that do not support this
function.
Therefore, we now store the db names locally in PouchLink, and rely on
it to remove the databases.