Skip to content

Conversation

lethemanh
Copy link
Contributor

@lethemanh lethemanh commented Oct 1, 2025

Change:

Disable the Tablerow when componentsProps.tableRow.disabled is set

Related to:

cozy/cozy-drive#3516

Copy link

bundlemon bot commented Oct 1, 2025

BundleMon

Unchanged files (3)
Status Path Size Limits
dist/cozy-ui.min.css
20.02KB -
transpiled/react/stylesheet.css
17.74KB -
dist/cozy-ui.utils.min.css
10.97KB -

No change in files bundle size

Groups updated (1)
Status Path Size Limits
transpiled/react/**
1.03MB (+74B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@JF-Cozy
Copy link
Collaborator

JF-Cozy commented Oct 1, 2025

If think "all" is in the title : "Disable table row on cut". So here, we want the ability to disable row. That's for the "what". The how is "on cut" but cozy-ui doesn't care about the "how" here, it's the app responsibility.

So the question is : how to disable a row. We have already componentsProps to help us pass some props to deep components, we can rely on it. It should be componentsProps.tableRow.disabled, and get it in TableRow comp like you did const isDisabled = disabled || itemsInDropProcess.includes(item._id) and I think we are done

@lethemanh lethemanh force-pushed the disable-table-row-on-cut branch from b9fb6ca to cd35a2d Compare October 1, 2025 08:39
@lethemanh lethemanh requested a review from rezk2ll October 1, 2025 08:39
@rezk2ll rezk2ll changed the title feat: Disable table row on cut ✨ feat(virtualized table): Disable table row on componentsProps.tableRow.disabled Oct 1, 2025
@rezk2ll rezk2ll merged commit 41f8c1d into master Oct 1, 2025
12 checks passed
@rezk2ll rezk2ll deleted the disable-table-row-on-cut branch October 1, 2025 09:24
@cozy-bot
Copy link

cozy-bot commented Oct 1, 2025

🎉 This PR is included in version 130.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants