Add AppFullTitle component #2757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twake apps text icons use linear gradients and a new font called Cal Sans. Font is 100KB so it's lighter to use svg icons that adds only 23KB. To manage dark mode, we can change the fill attribute of TwakeText. Other icons are dark mode friendly.
Display the full title of an app with icon, brand name and app name. Support Twake theme only. It fallbacks on AppTitle with AppTitle API if app is not supported. It is a new component so that AppTitle stays light. AppFullTitle adds all Twake apps text icons so 23KB.
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages
See https://zatteo.github.io/cozy-ui/react/#!/Core/AppFullTitle