feat: Revert "feat: Set pdf-lib as a peerDep" #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15604af. Setting pdf-lib as a peerDep makes bundles errors when building even if do not need pdf-lib. I need to understand better how it works to propose a better solution. BREAKING CHANGE: Remove pdf-lib as a dep in your app if you added it in cozy-ui 120.0.0
zatteo
force-pushed
the
fix/revert-peer-deps
branch
from
1009072 to
503b454
Compare
zatteo
changed the title
BundleMonUnchanged files (3)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
approved these changes
Mar 13, 2025
|
🎉 This PR is included in version 121.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 15604af.
Setting pdf-lib as a peerDep makes bundles errors when building even if do not need pdf-lib. I need to understand better how it works to propose a better solution.
BREAKING CHANGE: Remove pdf-lib as a dep in your app if you added it in cozy-ui 120.0.0