feat: Set pdf-lib as a peerDep #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (3)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
on devrait mettre la version dans le message du BC car elle est fixée, voir même la commande yarn exacte à taper ce serait plus simple pour le développeur |
zatteo
force-pushed
the
feat/peerdep-pdf-lib
branch
from
e4243a2 to
15d400e
Compare
JF-Cozy
approved these changes
Mar 11, 2025
pdf-lib adds 381KB to an app bundle and is rarely used so let's set it as a peer dep. BREAKING CHANGE: If you use print action, please add pdf-lib as a dep in your app because it is now a peerDep in cozy-ui. `yarn add [email protected]`
zatteo
force-pushed
the
feat/peerdep-pdf-lib
branch
from
15d400e to
b2c5fab
Compare
|
🎉 This PR is included in version 120.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdf-lib adds 381KB to an app bundle and is rarely used so let's set it as a peer dep.
BREAKING CHANGE: If you use print action, please add pdf-lib as a dep in your app because it is now a peerDep in cozy-ui