Spread prop on SearchBar and set important on utility classes #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
reviewed
Oct 14, 2024
|
|
||
| bdrs-0() | ||
| border-radius rem(0) | ||
| border-radius rem(0) !important // @stylint ignore |
Member
There was a problem hiding this comment.
Is there an explanation of why the !important is needed ? Can we add it ?
Collaborator
Author
There was a problem hiding this comment.
On a pas mal de classe utilitaires qui sont en important, justement parce que ce sont des classes utilitaires et qu'elles doivent prendre la main sur le css de l'app. Et certaines classes ne le sont pas, ce qui fait qu'elles ne servent à rien dans le cas d'un div qui a déjà le style correspondant définit, puisque le css de l'app est chargé en dernier.
zatteo
approved these changes
Oct 14, 2024
|
🎉 This PR is included in version 111.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages