[VO-710] feat: Add Markdown component #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
requested review from
JF-Cozy,
Ldoppea,
Merkur39 and
zatteo
as code owners
JF-Cozy
approved these changes
Sep 5, 2024
react/Markdown/index.jsx
Outdated
| ) | ||
| } | ||
|
|
||
| export { Markdown } |
There was a problem hiding this comment.
je sais qu'il y a débat, mais par souci de cohérence, peut-on faire une export par défaut stp ? 90% des composants de cozy-ui sont en default.
cballevre
force-pushed
the
feat/add-markdown
branch
from
d6c19bc to
e5e53df
Compare
|
🎉 This PR is included in version 111.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is responsible to render Markdown with Cozy design. At Cozy, we use component to style whereas React-markdown transform markdown with html tag only so the style is not correct. In some apps (cozy-settings, cozy-store, harvest, cozy-ui) we already use this library but each time make a new version of the wrapper. This PR allows you to share the component and its styles between apps.
You can found a demo on my github : https://cballevre.github.io/cozy-ui/react/#!/Core/Markdown