Skip to content

Conversation

zatteo
Copy link
Member

@zatteo zatteo commented Dec 11, 2024

### ✨ Features

*

### 🐛 Bug Fixes

*

### 🔧 Tech

* Remove unused packages

@zatteo zatteo force-pushed the feat/remove-unused-packages branch from f56ea19 to a61a507 Compare December 11, 2024 16:36
Copy link

bundlemon bot commented Dec 11, 2024

BundleMon

Files updated (2)
Status Path Size Limits
public/photos.(hash).js
1.22MB (+12.88KB +1.04%) -
vendors/photos.(hash).js
1.23MB (+5.92KB +0.47%) -
Unchanged files (9)
Status Path Size Limits
services/onPhotoUpload/photos.js
266.49KB -
services/onPhotoTrashed/photos.js
256.88KB -
public/cozy-client-js.js
159.28KB -
app/photos.(hash).js
57.12KB -
public/photos.(hash).min.css
46.47KB -
app-photos.(hash).min.css
19.75KB -
manifest.webapp
1.12KB -
index.html
514B -
manifest.json
185B -

Total files change +18.8KB +0.57%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

"@testing-library/react": "11.2.7",
"@testing-library/react-hooks": "8.0.1",
"@types/react-redux": "7.1.26",
"@welldone-software/why-did-you-render": "^6.1.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

celui-là tu peux le laisser, c'est une condition à activer ou non dans le code pour s'en servir, mais il faut que le package soit là. Si la condition n'est pas présente, il faut donc la rajouter (voir sur les autres repo)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je l'ai rajouté comme sur Drive 👍

Remaining from the separation of drive and photos.
Setup was removed by mistake during the split with cozy-drive.
@zatteo zatteo force-pushed the feat/remove-unused-packages branch from a61a507 to d2d2530 Compare December 20, 2024 14:26
@zatteo zatteo merged commit 0f970a6 into master Dec 20, 2024
4 checks passed
@zatteo zatteo deleted the feat/remove-unused-packages branch December 20, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants