Skip to content

fix(useOnLongPress): clearTimeout should be inside a func #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

fix(useOnLongPress): clearTimeout should be inside a func #3556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hooks/useOnLongPress/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ export const makeDesktopHandlers = ({
}) => {
return {
// first event triggered on Desktop
onMouseDown: clearTimeout(timerId.current),
onMouseDown: () => clearTimeout(timerId.current),
// second event triggered on Desktop
onMouseUp: clearTimeout(timerId.current),
onMouseUp: () => clearTimeout(timerId.current),
// third event triggered on Desktop
onClick: event =>
handleClick({
Expand Down Expand Up @@ -145,9 +145,9 @@ export const makeMobileHandlers = ({
// first event triggered on Mobile when taping an item
onTouchStart: startPressTimer,
// second event triggered on Mobile when dragging an item
onTouchMove: clearTimeout(timerId.current),
onTouchMove: () => clearTimeout(timerId.current),
// third event triggered on Mobile when taping an item
onTouchEnd: clearTimeout(timerId.current),
onTouchEnd: () => clearTimeout(timerId.current),
// fourth event triggered on Mobile
onClick: event =>
handlePress({
Expand Down
Loading