Skip to content

Conversation

nicolasrenardcozy
Copy link

Readme updated with new scrapped data from connectors

"identifier": "[email protected]",
"contact": {
"address": [
"addresses": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in favor of changing those keys. contact entry here, is the same as our io.cozy.contacts doctype. And in this doctype, we use the singular https://github.com/cozy/cozy-doctypes/blob/master/docs/io.cozy.contacts.md

Can we revert those changes? 🙏 .

"1AJ": "12345.67",
"1BJ": "23456.78",
"currency": "EUR",
"file": "avis_impot_2022.pdf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that the filename is useful since it can be renamed for instance. Can't we use a relationship here?

"tax_informations": [
    {
      "year": "2022",
      "RFR": "56789.10",
      "1AJ": "12345.67",
      "1BJ": "23456.78",
      "currency": "EUR",
      "relationship": {
           "type": "io.cozy.files", 
           "_id": XXX
       }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants