Skip to content

Fix VirtualizedList order #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2025
Merged

Fix VirtualizedList order #1062

merged 3 commits into from
Sep 22, 2025

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Sep 22, 2025

No description provided.

@JF-Cozy
feat: Upgrade cozy-ui
ab0d912
@JF-Cozy
fix(ContractInfoTitle): Aria-label wasn't the good one for favorite b…
5b6e330 
…utton
@JF-Cozy
fix(VirtualizedList): Contact order wasn't right
a69bc89 
don't need to use defaultOrder to sort twice the list (already sorted
in the app before table instantiation). We use categorizedContacts
here like we did in the old table to sort correctly
@JF-Cozy JF-Cozy requested a review from zatteo as a code owner September 22, 2025 08:08
@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 22, 2025

BundleMon

Files updated (2)
Status Path Size Limits
✅ static/js/cozy.(hash).js
 531.3KB (+121B +0.02%) -
✅ static/js/main.(hash).js
 263.9KB (+26B +0.01%) -
Unchanged files (8)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 542.88KB -
✅ services/autoDefineLabels.js
 243.22KB -
✅ services/keepIndexFullNameAndDisplayNameUpToD
ate.js
 243KB -
✅ services/cleanRelatedContacts.js
 242.62KB -
✅ static/js/lib-react.(hash).js
 44.11KB -
✅ static/css/cozy.(hash).css
 29.39KB -
✅ static/js/lib-router.(hash).js
 21.86KB -
✅ static/css/main.(hash).css
 1.11KB -

Total files change +147B +0.01%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 3.49MB (+298B +0.01%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 1.15MB -
✅ **/*.css
 58.67KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 2a95f29 into master Sep 22, 2025
2 checks passed
@JF-Cozy JF-Cozy deleted the fix/favorites branch September 22, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rezk2ll rezk2ll rezk2ll approved these changes

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JF-Cozy @rezk2ll