Fix file paths handling for Pouch #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of this, paths Map was not properly initialized
We keep file paths in-memory for fast retrieval, as they are not stored in database. If a file was updated, its path was not correctly updated in the paths Map.
zatteo
approved these changes
Oct 3, 2025
paultranvan
added a commit
to cozy/cozy-libs
that referenced
this pull request
Oct 3, 2025
paultranvan
added a commit
to cozy/cozy-libs
that referenced
this pull request
Oct 3, 2025
paultranvan
added a commit
to cozy/cozy-libs
that referenced
this pull request
Oct 3, 2025
paultranvan
added a commit
to cozy/cozy-libs
that referenced
this pull request
Oct 3, 2025
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Oct 3, 2025
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File paths are not stored in PouchDB. Therefore, we keep a Map of paths in-memory, for fast retrieval.
This PR adds 2 fixes:
Note the paths were still properly displayed to the user at search time, because the paths handling was originally done on search side: https://github.com/cozy/cozy-libs/blob/master/packages/cozy-dataproxy-lib/src/search/helpers/filePaths.ts
But this is better to mutualize the logic here, so both search and pouch queries can benefit from it. So we'll eventually remove the paths handling on dataproxy search.