Skip to content

Support shared drive for Notes creation and fetch #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2025
Merged

Support shared drive for Notes creation and fetch #1628

merged 3 commits into from
Sep 5, 2025

Conversation

zatteo
Copy link
Member

@zatteo zatteo commented Sep 5, 2025

No description provided.

@zatteo
fix: Add options to DocumentCollection constructor
48da4f5 
We start to have some collection having a options argument. Even if
it is not used in DocumentCollection for the moment, we forward it
with `super` so here I add it in DocumentCollection to fix typing.
@zatteo
refactor: Move sharedDriveApiPrefix in collection utils
8eb34bf
@zatteo zatteo requested a review from paultranvan as a code owner September 5, 2025 05:38
@zatteo zatteo force-pushed the feat/support-sharing-in-note branch from f5cc156 to de8552d Compare September 5, 2025 05:39
@zatteo zatteo mentioned this pull request Sep 5, 2025
Merged
1 task
taratatach
taratatach reviewed Sep 5, 2025
View reviewed changes
Copy link
Member

@taratatach taratatach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you add the prefix to the destroy method as well since it's using the io.cozy.files API?

@zatteo
Copy link
Member Author

zatteo commented Sep 5, 2025

Shouldn't you add the prefix to the destroy method as well since it's using the io.cozy.files API?

Totally 👍

@zatteo
feat: Support shared drive for note creation and fetch
ac5e098 
Using the same way than for FileCollection.

Implementing new routes added here
cozy/cozy-stack#4557
@zatteo zatteo force-pushed the feat/support-sharing-in-note branch from de8552d to ac5e098 Compare September 5, 2025 14:19
@zatteo zatteo merged commit 2a6a003 into master Sep 5, 2025
3 checks passed
@zatteo zatteo deleted the feat/support-sharing-in-note branch September 5, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taratatach taratatach taratatach left review comments

@rezk2ll rezk2ll rezk2ll approved these changes

@paultranvan paultranvan Awaiting requested review from paultranvan paultranvan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zatteo @taratatach @rezk2ll