Add shared drive option when creating a sharing #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is deprecated for 4 years. It does not seem to be used in our apps. BREAKING CHANGE: SharingCollection.share method has been removed. Use SharingCollection.create method.
This deprecated argument was not used anymore in our code AND the getSharingRules was exposed. So we can remove it and we do not need to flag this as a breaking change.
Shared drive sharing have special sharing rules.
zatteo
force-pushed
the
feat/shared-drives
branch
from
c017090 to
1030972
Compare
This was referenced Feb 24, 2025
paultranvan
approved these changes
Feb 24, 2025
Better name, not a breaking change since it was not merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shared drive option when creating a sharing. I also included some refactoring too.