fix: Stop deleting active uninstall key at startup - #2462
Merged
Conversation
taratatach
force-pushed
the
bring-back-windows-uninstall-entry
branch
from
August 25, 2026 09:39
5c6f6d1 to
4379c67
Compare
Windows lists installed apps from the Uninstall registry subkeys. Every launch, Twake Desktop removed what it believed was a stale key from the electron-builder v19 era: the brace-less uninstall key. When electron-builder was bumped from v19 to v21 (v3.16.0), the NSIS template started writing the key with braces, so that cleanup only removed the orphaned brace-less one. But v22 reverted the template back to the brace-less form, making the `OLD_UNINSTALL_KEY` in `core/utils/win_registry.js` identical to the active key written by every installer since. The app silently deleted its own uninstall entry on each launch and disappeared from Windows' installed apps list. Remove the startup cleanup entirely.
Its only consumer, the startup registry cleanup in `core/utils/win_registry.js`, is gone, so the package and the `extraResources` entry copying `node_modules/regedit/vbs` into the packaged app go with it.
The installer (and auto-updater, which runs the same installer with `/S --updated`) now removes the braced uninstall registry key left behind by the electron-builder v21 era installers, plus its brace-less per-machine variant from the v19 era, so a single Twake Desktop entry ever shows up in Windows' installed apps list. The key currently written by the installer (no braces, in `SHELL_CONTEXT`) is never touched.
taratatach
force-pushed
the
bring-back-windows-uninstall-entry
branch
from
August 26, 2026 12:53
4379c67 to
b4ff62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows lists installed apps from the Uninstall registry subkeys. Every
launch, Twake Desktop removed what it believed was a stale uninstall
entry and disappeared from Windows' installed apps list.
Please make sure the following boxes are checked: