feat: Skip dependants of skipped changes - #2455
Merged
Merged
Conversation
taratatach
force-pushed
the
feat/skip-dependants-of-skipped-changes
branch
from
July 7, 2026 14:48
02a5991 to
494b634
Compare
shepilov
reviewed
Jul 8, 2026
taratatach
force-pushed
the
feat/skip-dependants-of-skipped-changes
branch
from
July 16, 2026 14:06
494b634 to
ca7916b
Compare
A skipped change left its dependants unprotected: on the next cycle they would be attempted and either fail spuriously (e.g. `MISSING_PARENT`) or, worse, succeed partially and create an orphan. The multi-error loop makes this more visible since dependants are no longer shielded by the first-failure break. When a change is skipped (automatically via `handleSyncError` returning `'skipped'`, or by the user), the `syncBatch` loop now adds it to `blockedIds`. Dependents detected via `directPrerequisites` whose prereq has `doc.skipped === true` are themselves skipped (`skipChange` persists the flag) and emit a synthetic `SKIPPED_DEPENDENCY` alert. `blockedIds` propagates the skip transitively across the topologically ordered batch. The synthetic `SyncError` carries `prereqPath` as a dedicated field, transported by `makeAlert` to the GUI. `viewByCode` interpolates it into a localized message with the path wrapped in backticks. The restored `Util.DecorationParser` parses those backticks in `alertContent`, and `decoratedName` renders the path as a clickable chip (blue background, `title` with full path, `ShowInParent` on click).
taratatach
force-pushed
the
feat/skip-dependants-of-skipped-changes
branch
from
July 16, 2026 15:03
ca7916b to
d67c1e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A skipped change left its dependants unprotected: on the next cycle
they would be attempted and either fail spuriously (e.g.
MISSING_PARENT) or, worse, succeed partially and create anorphan. The multi-error loop makes this more visible since
dependants are no longer shielded by the first-failure break.
When a change is skipped (automatically via
handleSyncErrorreturning
'skipped', or by the user), thesyncBatchloop nowadds it to
blockedIds. Dependents detected viadirectPrerequisiteswhose prereq hasdoc.skipped === truearethemselves skipped (
skipChangepersists the flag) and emit asynthetic
SKIPPED_DEPENDENCYalert.blockedIdspropagatesthe skip transitively across the topologically ordered batch.
The synthetic
SyncErrorcarriesprereqPathas a dedicatedfield, transported by
makeAlertto the GUI.viewByCodeinterpolates it into a localized message with the path wrapped
in backticks. The restored
Util.DecorationParserparses thosebackticks in
alertContent, anddecoratedNamerenders the pathas a clickable chip (blue background,
titlewith full path,ShowInParenton click).Fixes #2436
Please make sure the following boxes are checked: