fix: Use ARM macOS update metadata - #2449
Merged
Merged
Conversation
taratatach
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2443
Why it was broken
The release assets were already generated correctly: ARM macOS releases publish latest-arm64-mac.yml and x64 macOS releases publish latest-mac.yml.
The actual problem was the runtime metadata lookup, not publishing: although ARM builds correctly published latest-arm64-mac.yml and were packaged with channel: latest-arm64, electron-updater@4.1.2 ignored the configured channel for the GitHub provider and always computed the default macOS metadata file via getDefaultChannelName(), which resolves to latest-mac.yml; as a result, an ARM app requested latest-mac.yml, received metadata pointing to Twake-Desktop-x64.zip, and downloaded the x64 update.
Newer electron-updater versions read this.updater.channel || this.options.channel for GitHub, so the packaged latest-arm64 channel is combined with the macOS suffix and the ARM app requests latest-arm64-mac.yml as intended.