fix: Properly order dependent moves in sync - #2447
Merged
Merged
Conversation
`compareChanges` returned `KEEP_ORDER` for two chained moves where one frees the path the other takes (e.g. `i` → `i*` followed by `j` → `i`). The dependent move could run before its destination was freed, failing with a "destination already exists" error. We now detect this case in `compareChanges` — both ops are `MOVE` with a `moveFrom` and one's destination equals the other's source — and order the freeing move first.
taratatach
force-pushed
the
fix/order-dependent-moves-in-sync
branch
from
July 3, 2026 15:18
1733470 to
f0c041e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compareChangesreturnedKEEP_ORDERfor two chained moves where onefrees the path the other takes (e.g.
i→i*followed byj→i). The dependent move could run before its destination wasfreed, failing with a "destination already exists" error.
We now detect this case in
compareChanges— both ops areMOVEwitha
moveFromand one's destination equals the other's source — andorder the freeing move first.
Fixes #2445
Please make sure the following boxes are checked: