fix: invoke zeroshot via node on Windows#473
Open
haosenwang1018 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildZeroshotSpawnSpec()helper for self-invocationprocess.execPathwithcli/index.jsinstead of trying to execute barezeroshotagent-task-executorandclaude-task-runnerWhy
Issue #457 reports that
spawn('zeroshot', ...)fails on Windows because npm global commands are exposed as.cmdwrappers, which Node cannot execute the same way as Unix binaries.This PR fixes the smallest high-impact part first: zeroshot spawning itself. On Windows it now invokes Node directly with the CLI script path, avoiding the
.cmdwrapper and the resultingENOENTfailures.Testing
./node_modules/.bin/mocha tests/providers/detection.test.jsPart of #457