Repository navigation
fix: [COVAL-9263] require HTTPS for custom API URLs - #11
Merged
Merged
Conversation
jakelevi
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate custom
api_base_urlformats consistently for voice, text and trace uploads. The defaulthttps://api.coval.dev/v1remains unchanged.Custom API roots use HTTPS. Integrations using a nonlocal
http://root must switch tohttps://before upgrading. HTTP remains supported for local development withlocalhostor unscoped loopback IP literals. Custom roots must not contain user information, query strings or fragments and must use valid URL components. Configure the final API root directly. Redirect responses are reported as SDK errors.Tests cover both public client constructors, supported and unsupported URL formats, redirect responses for GET, JSON POST and protobuf POST, and trace uploads after correcting the API root. No runtime dependency, package version or release workflow changes.
Validation at head
5fab80f: pinned Ruff checks and formatting, architecture checks, strict type checks, distribution build/metadata/base-install checks, and installed-wheel tests passed on Python 3.10, 3.12 and 3.14. Each Python job passed 286 tests and 49 subtests. All 25 release-tooling tests and required PR checks passed. CI run.Linear: https://linear.app/coval/issue/COVAL-9263/require-https-for-custom-agent-sdk-api-urls