Throw error when building results in uncommitted changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall running into this, I think when there was an auto-format fix flag enabled even in CI (I think I disabled the auto format in CI to fix that). Good idea to assert on this. Would be good to add a diff of the unexpected changes to the error message. Other than that, it LGTM. |
core/src/DefaultBuilder.ts
Outdated
| @@ -153,6 +153,11 @@ class DefaultBuilder implements Builder { | |||
| throw new Error(errors.join('\n====\n') || 'Unknown error while building') | |||
| }) | |||
|
|
|||
| if (await doPromiseExec('git status --short', { cwd: workingDir })) { | |||
| await doPromiseExec('git reset --hard && git clean -fd', { cwd: workingDir }) | |||
| throw new Error(`Building ${componentLibrary} resulted in uncommitted changes`) | |||
There was a problem hiding this comment.
"resulted in unexpected changes" would be more insightful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If building a component library results in uncommitted changes, throw an error.
Currently, those uncommitted changes hang around, and then if a new commit tries to modify the same file, we get an error that the local changes would be overwritten by merge. I think it would be preferable to fail the original build so that the committer realizes they need to push the changes that result from building.