This repository was archived by the owner on Apr 11, 2024. It is now read-only.
add supported versions of python and django#30
Open
kreneskyp wants to merge 2 commits intocounsyl:masterfrom
Open
add supported versions of python and django#30kreneskyp wants to merge 2 commits intocounsyl:masterfrom
kreneskyp wants to merge 2 commits intocounsyl:masterfrom
Conversation
ctk3b
approved these changes
Feb 22, 2022
ctk3b
left a comment
ctk3b
left a comment
There was a problem hiding this comment.
LGTM % version typo fix and confirming the tests passed on all configs 😁
Also hi @kreneskyp !
| 2.2: Django>=2.2,<3.0 | ||
| 3.0: Django>=3.0,<3.1 | ||
| 3.1: Django>=3.1,<3.2 | ||
| 3.2: Django>=2.2,<4.0 |
There was a problem hiding this comment.
Suggested change
| 3.2: Django>=2.2,<4.0 | |
| 3.2: Django>=3.2,<4.0 |
Author
|
I'm actually having trouble running tests locally. Was hoping this repo had CI hooked up to it still but it apparently does not. |
Author
oh hey there! @ctk3b |
I don't have admin but if you do, I found it very easy to get set up with github actions and tox https://github.com/insitro/redun/blob/main/.github/workflows/test_pull_request.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more tox options to test newer and wider set of python and django version
changes
How tested