GOCBC-1780: Remove go-grpc-middleware #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the go-grpc-middleware dependency by replacing it with direct usage of grpclog for setting the gRPC logger. The change simplifies the codebase by using gRPC's built-in logging functionality instead of an external middleware library.
Key Changes:
- Replaced
grpc_logsettable.ReplaceGrpcLoggerV2().Set()withgrpclog.SetLoggerV2() - Removed
go-grpc-middlewaredependency fromgo.mod - Updated OpenTelemetry and goprotostellar dependencies to newer versions
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| routingclient.go | Replaced middleware-based logger setup with direct grpclog usage and reorganized imports |
| go.mod | Removed go-grpc-middleware dependency and updated OpenTelemetry/goprotostellar versions |
| routingconn.go | Reorganized import statements for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chvck
force-pushed
the
gocbc-1780_update_deps
branch
2 times, most recently
from
c0a1264 to
c0958ca
Compare
Motivation ---------- We use go-grpc-middleware for setting the grpc level logger. We can achieve the same via grpclog itself directly. Whilst go-grpc-middleware can be used for request level logging we do not require that. Changes ------- Remove go-grpc-middleware dependency.
chvck
force-pushed
the
gocbc-1780_update_deps
branch
from
c0958ca to
e248773
Compare
Westwooo
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We use go-grpc-middleware for setting the grpc level logger. We can achieve the same via grpclog itself directly. Whilst go-grpc-middleware can be used for request level logging we do not require that.
Changes
Remove go-grpc-middleware dependency.