Catch exceptions inside c4queryobs_setEnabled() #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speculative fix for intermittent crash observed by a customer. This API function calls into C4Query::enableObserver(), which is a pretty complex method that is not marked `noexcept`, so it's possible it sometimes throws, causing the crash in `std::terminate` seen in customer's crash logs.
snej
force-pushed
the
fix/safer_c4queryobs_setEnabled
branch
from
b8eff67 to
93c5fb9
Compare
|
Code Coverage Results:
|
pasin
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for intermittent crash observed by a customer. This API function calls into C4Query::enableObserver(), which is a pretty complex method that is not marked
noexcept, so it's possible it sometimes throws, causing the crash instd::terminateseen in customer's crash logs.