Fix mutex panic in BatchWithFlusher when Write() returns error #1136
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lock/unlock mismatch in
BatchWithFlusher.SetandDeletethat can cause a runtime panic whenWrite()returns an error on the flush path.Both methods use
defer b.mtx.Unlock()while also manually unlocking the mutex prior to callingWrite(). IfWrite()fails, the function returns while the mutex is already unlocked, and the deferredUnlock()triggers:Changes
Unlock().Impact
BatchWithFlushersafe whenWrite()can legitimately fail (e.g., alternative backends, injected faults, or stricter error handling).Notes
This change intentionally does not alter higher-level error handling semantics for failed writes; it only ensures mutex correctness and stability.
If you want, I can also: