-
Notifications
You must be signed in to change notification settings - Fork 301
docs: fixed dead link in PERFORMANCE.md
#1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA single documentation update was made to the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
PERFORMANCE.md (1)
76-78
: Fix list indentation to satisfy markdownlint MD007.Static analysis flagged an unordered list indent of 2 spaces at lines 76–78. Top-level bullets should have zero leading spaces. For example:
-* [Profiling benchmarks locally](https://medium.com/@hackintoshrao/daily-code-optimization-using-benchmarks-and-profiling-in-golang-gophercon-india-2016-talk-874c8b4dc3c5#.jmnd8w2qr) -* [Profiling running programs](https://blog.ralch.com/articles/golang-performance-and-memory-analysis/) -* [Dave Chenny's profiler pkg](https://github.com/pkg/profile) +* [Profiling benchmarks locally](https://medium.com/@hackintoshrao/daily-code-optimization-using-benchmarks-and-profiling-in-golang-gophercon-india-2016-talk-874c8b4dc3c5#.jmnd8w2qr) +* [Profiling running programs](https://blog.ralch.com/articles/golang-performance-and-memory-analysis/) +* [Dave Chenny's profiler pkg](https://github.com/pkg/profile)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
76-76: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
77-77: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
78-78: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
PERFORMANCE.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
PERFORMANCE.md
77-77: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🔇 Additional comments (1)
PERFORMANCE.md (1)
77-77
:✅ Verification successful
Corrected the dead link; verify the new URL is reachable.
The link has been updated to use HTTPS and the
/articles/
path, which aligns with the current resource location. Please confirm the URL returns a 200 OK status to ensure it resolves correctly.You can run:
🏁 Script executed:
#!/bin/bash curl -I https://blog.ralch.com/articles/golang-performance-and-memory-analysis/ | head -n 1Length of output: 501
✅ Updated link verified
The URLhttps://blog.ralch.com/articles/golang-performance-and-memory-analysis/
returns HTTP/2 200 OK as expected. No further changes needed.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
77-77: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
Hi! I found a dead link in the performance guide — the old blog URL used
http
and an outdated path format.Summary by CodeRabbit