refactor: systemtests #720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vladjdk
approved these changes
Oct 22, 2025
evmd/upgrades.go
Outdated
| // Persist the EVM coin metadata in keeper state. Chains bootstrapped on earlier | ||
| // binaries never stored this information (it lived only in process globals), | ||
| // so migrating nodes would otherwise see an empty EvmCoinInfo on upgrade. | ||
| if err := app.EVMKeeper.InitEvmCoinInfo(sdkCtx); err != nil { |
There was a problem hiding this comment.
We have this a few lines down - why do we need to initialize this twice?
| }, | ||
| }, | ||
| { | ||
| // NOTE: Skip this test for now |
There was a problem hiding this comment.
Gonna need to investigate this one
vladjdk
approved these changes
Oct 22, 2025
|
Approved with a few nits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #741
Changes
Consequence
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch