Conversation
Contributor
|
PR author is not in the allowed authors list. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26820 +/- ##
==========================================
+ Coverage 64.97% 65.02% +0.04%
==========================================
Files 785 785
Lines 55413 55425 +12
==========================================
+ Hits 36007 36038 +31
+ Misses 19406 19387 -19
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26469
autocliServiceRegistrarstored a singleserviceNameand overwrote it on everyRegisterServicecall. A module that registers more than one msg or query service therefore had all but the last service silently dropped from the AutoCLI command tree.The
ServiceCommandDescriptorproto already supports this:servicemay be left empty whensub_commandsare used for modules with multiple tx/query services. This wires the registrar up to that support.Change
newServiceCommandDescriptor: first service stays primary (single-service modules unchanged); additional services become sub-commands keyed by lowercased short name, falling back to the fully qualified name on collision.Testing