Conversation
Contributor
|
PR author is not in the allowed authors list. |
kriss39
force-pushed
the
fix/auth-tx-adapt-nested-modeinfos
branch
from
September 13, 2026 20:13
45f8571 to
37083dd
Compare
dianab-cl
requested changes
Sep 14, 2026
dianab-cl
left a comment
Contributor
There was a problem hiding this comment.
Please Sign the commits
adaptModeInfo allocated the modeInfos slice for a multisig ModeInfo but adapted every nested entry into a throwaway struct, so the converted ModeInfo_Multi carried a slice of nil pointers instead of the sub-signer mode infos. Store the converted entries in the slice.
kriss39
force-pushed
the
fix/auth-tx-adapt-nested-modeinfos
branch
from
September 14, 2026 08:43
37083dd to
8f265eb
Compare
Author
|
Done — replaced the commit with a signed one (ce7b429, same content), now shows as Verified. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26815 +/- ##
==========================================
+ Coverage 64.97% 64.99% +0.01%
==========================================
Files 785 785
Lines 55413 55414 +1
==========================================
+ Hits 36007 36016 +9
+ Misses 19406 19398 -8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adaptModeInfo(used bywrapper.GetSigningTxDatato convert the gogoprotoAuthInfointo thex/txTxData) allocates themodeInfosslice for a multisigModeInfobut adapts every nested entry into a throwaway&txv1beta1.ModeInfo{}and never stores it:The converted
ModeInfo_Multitherefore carries a slice of nil pointers instead of the sub-signer mode infos. The current sign mode handlers do not read this field (DIRECT uses the rawAuthInfoBytes), so this has been latent since #15910, but any handler or downstream consumer that inspectsTxData.AuthInfo.SignerInfos[i].ModeInfo.GetMulti().ModeInfosgets nil entries. Same function as the recent nilMulti/Bitarrayfix in #26571.Changes
modeInfos[i].TestGetSigningTxData_MultisigModeInfos: a 2-of-2 multisig signature with a DIRECT and a LEGACY_AMINO_JSON sub-signer; asserts both nested mode infos are present and carry the right modes. Fails onmain(Expected value not to be nil).