feat: add SetDERConversion to reset skipDERConversion #25435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Ledger app name
|
Can you document how a user could make the change that this is enabling? |
aljo242
reviewed
Oct 14, 2025
crypto/ledger/ledger_secp256k1.go
Outdated
Comment on lines
133
to
135
| func SetDERConversion() { | ||
| options.skipDERConversion = false | ||
| } |
There was a problem hiding this comment.
I feel like this should have an argument so you can set to true or false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Ledger app name
Description
change to allow switch Cosmos and Ethereum app when using different cointype like cosmos/evm#690